Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add separate license check #4727

Merged
merged 6 commits into from
Aug 23, 2024
Merged

ci: add separate license check #4727

merged 6 commits into from
Aug 23, 2024

Conversation

jmayclin
Copy link
Contributor

Description of changes:

Ensure that the license and the copyright is always included.

Testing:

I tested this by reducing the number of lines that it checked for and confirming that error were emitted. For example, if you only use head -4 instead of head -5, the following errors are printed out

License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/lib/utils/s2n_safety_macros.h
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/lib/utils/s2n_rfc5952.h
License Check Failed: /home/ec2-user/workspace/s2n-tls/utils/s2n_rfc5952.h
License Check Failed: /home/ec2-user/workspace/s2n-tls/utils/s2n_safety_macros.h
License Check Failed: /home/ec2-user/workspace/s2n-tls/tests/fuzz/s2n_extensions_client_supported_versions_recv_test.c
License Check Failed: /home/ec2-user/workspace/s2n-tls/codebuild/bin/install_apache2.sh
License Check Failed: /home/ec2-user/workspace/s2n-tls/codebuild/bin/install_gnutls37.sh
License Check Failed: /home/ec2-user/workspace/s2n-tls/codebuild/bin/install_shellcheck.sh
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/internal.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/quic.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/crl.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/fingerprint.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/npn.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/ktls.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/features/renegotiate.rs
License Check Failed: /home/ec2-user/workspace/s2n-tls/bindings/rust/s2n-tls-sys/src/api.rs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Aug 22, 2024
@jmayclin jmayclin marked this pull request as ready for review August 22, 2024 21:28
@jmayclin jmayclin requested a review from dougch as a code owner August 22, 2024 21:28
@jmayclin jmayclin requested a review from goatgoose August 22, 2024 21:29
- rename the CI workflow to reflect the name change
@jmayclin jmayclin requested a review from goatgoose August 22, 2024 22:02
@jmayclin jmayclin enabled auto-merge (squash) August 22, 2024 22:04
@jmayclin jmayclin merged commit 064723f into aws:main Aug 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants