Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump versions of aws-lc and aws-lc-fips #4716

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Aug 20, 2024

Resolved issues:

Partial for #4710

Description of changes:

We're pinning the versions of aws-lc and aws-lc-fips in CI, nix and our docker containers.

Call-outs:

  • Because the flake is updated, the nix CI jobs are actually testing the new version of aws-lc
  • This change won't make it into the regular CI jobs until the custom CodeBuild Docker containers are rebuilt (quick followup to this PR).
  • The s2n_mem_usage_test was failing with 50KB/connection when awslc was built with musl; bumping to 51 resolves this in ad-hoc testing.

Testing:

How is this change tested: locally, unit tests pass

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Aug 20, 2024
@dougch dougch added the type/nix related to nix label Aug 20, 2024
Copy link
Contributor

@jmayclin jmayclin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any neat way to pin to the latest release? Might be nice to shift to in the future.

@dougch dougch requested a review from jmayclin August 21, 2024 17:27
@dougch
Copy link
Contributor Author

dougch commented Aug 21, 2024

re: the mem usage change, here are the exact numbers with musl from my debug run:

maxAllowedMemDiff: 110592000    
minAllowedMemDiff: 82944000      
handshake_diff: 110608384

https://github.com/aws/s2n-tls/blob/main/tests/unit/s2n_mem_usage_test.c#L277

@dougch dougch enabled auto-merge (squash) August 22, 2024 16:48
@dougch dougch merged commit b5dba3b into aws:main Aug 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2n-core team type/nix related to nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants