Update s2n_connection_get_kem_group_name() to work with ClientHelloRe… #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
Jul 16, 2024
jmayclin
approved these changes
Jul 16, 2024
alexw91
force-pushed
the
fix-2-rtt-kemgroup-getter
branch
from
57d895d to
85a7a8c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tries
Resolved issues:
N/A
Description of changes:
Updates
s2n_connection_get_kem_group_name()to return the Hybrid PQ KemGroup that the server negotiated (not the one that the client preferred and sent in it's ClientHello) in the event that a 2-RTT PQ Handshake occurs.Before #4526 these two values would have always been the same, but after this change (if a 2-RTT occurs where the server selects a PQ KemGroup that the Client didn't include a KeyShare for in the ClientHello) these values could differ.
Call-outs:
None
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
New unit tests added to check for this case.
Is this a refactor change? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.