Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pcap): handle pcaps with tcp fragmentation #4643

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Jul 7, 2024

Description of changes:

When I first wrote the pcap tests, I couldn't handle TCP fragmentation because the underlying rtshark library had a bug that prevented accessing the "tcp.reassembled.data" field: CrabeDeFrance/rtshark#16 rtshark has now been updated, so I updated the pcap tests.

I also updated a comment to reflect that I decided not to use the TLS fragmentation fix from CrabeDeFrance/rtshark#17.

Testing:

New test, using a pcap with a ClientHello fragmented at the TCP layer instead of the TLS layer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jul 7, 2024
@lrstewart lrstewart marked this pull request as ready for review July 7, 2024 05:40
@lrstewart lrstewart requested review from jmayclin and maddeleine July 7, 2024 05:42
@lrstewart lrstewart enabled auto-merge (squash) July 10, 2024 18:15
@lrstewart lrstewart merged commit d1c2a43 into aws:main Jul 11, 2024
34 checks passed
@lrstewart lrstewart deleted the tcp_frag branch July 11, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants