test(pcap): handle pcaps with tcp fragmentation #4643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When I first wrote the pcap tests, I couldn't handle TCP fragmentation because the underlying rtshark library had a bug that prevented accessing the "tcp.reassembled.data" field: CrabeDeFrance/rtshark#16 rtshark has now been updated, so I updated the pcap tests.
I also updated a comment to reflect that I decided not to use the TLS fragmentation fix from CrabeDeFrance/rtshark#17.
Testing:
New test, using a pcap with a ClientHello fragmented at the TCP layer instead of the TLS layer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.