Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change init and destroy_key return type to S2N_RESULT in s2n_cipher struct #4639

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Jul 2, 2024

Resolved issues:

Part of #3983

Description of changes:

  • Change return type of init and destroy_key from int to S2N_RESULT
    int (*init)(struct s2n_session_key *key);

    int (*destroy_key)(struct s2n_session_key *key);
  • Majority of changes are to adapt to correct return types, like converting S2N_SUCCESS to S2N_OK, POSIX_GUARD to POSIX_GUARD_RESULT, and etc.

Call-outs:

Testing:

  • Confirmed all unit tests pass. Will address any CI failures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jul 2, 2024
@jouho jouho marked this pull request as ready for review July 2, 2024 23:11
@jouho jouho requested review from maddeleine and lrstewart July 2, 2024 23:11
@jouho jouho enabled auto-merge (squash) July 10, 2024 17:29
@jouho jouho merged commit 706e228 into main Jul 10, 2024
37 checks passed
@jouho jouho deleted the refactor-return-type-cipher-key-init-destroy branch July 10, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants