api(bindings/s2n-tls)!: remove public testing feature #4623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
changed the title
jmayclin
changed the title
- silence clippy warnings about unused types
- correct references to unused Server mode
lrstewart
reviewed
Jun 27, 2024
- fully remove unused items
camshaft
approved these changes
Jun 28, 2024
lrstewart
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of my ongoing testing refactor, I was cleaning up our testing harnesses and am now 1 PR away from deleting the old one.
However, I realized that this is technically a breaking change because we were publicly exporting all of our test utilities if the☹️ . I'm guessing that we did this when the
testingfeature was enabledintegration/benches/handshake.rswas added so that we could use thePairstruct to easily do the handshake.I do not think that we actually need to treat this as a breaking change, as no one should be enabling the
testingfeature. However I wanted to break this out as a separate PR to make sure that it was properly reviewed.Description of changes:
testingmodule privatetestingfeaturetestingfeature, the handshake bench inintegrationtestingfeatureCallouts
Removing the
testingfeature, in addition to my earlier refactor (#4613) means that clippy now identifies some unused items. Those have been removed.Testing:
Everything should continue to build, all existing CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.