Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(bindings): fix new clippy lint #4536

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented May 2, 2024

Description of changes:

Address the new clippy lint

    Checking s2n-tls v0.2.4 (/home/runner/work/s2n-tls/s2n-tls/bindings/rust/s2n-tls)
error: assigning the result of `Clone::clone()` may be inefficient
   --> s2n-tls/src/connection.rs:717:21
    |
717 |                     *prev_waker = waker.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `prev_waker.clone_from(waker)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `-D clippy::assigning-clones` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`

Testing:

CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmayclin jmayclin changed the title style(bindings): fix new clippy lints style(bindings): fix new clippy lint May 2, 2024
@github-actions github-actions bot added the s2n-core team label May 2, 2024
@jmayclin jmayclin marked this pull request as ready for review May 2, 2024 19:28
@jmayclin jmayclin enabled auto-merge (squash) May 2, 2024 19:47
@jmayclin jmayclin merged commit 67b807e into aws:main May 2, 2024
34 checks passed
@jmayclin jmayclin deleted the new-clippy branch August 29, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants