ci: grep for S2N_RESULT_ERR without setting s2n_errno #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouho
approved these changes
May 2, 2024
maddeleine
approved these changes
May 2, 2024
dougch
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4513 (comment)
Description of changes:
Our existing grep checks for posix return types, but not S2N_RESULT return types. So it misses
return S2N_RESULT_ERRORmistakes.Testing:
The updated script found a couple existing mistakes, which I fixed. The only actual problem was
s2n_async_get_actions. The other instances didn't set s2n_errno, but relied on a previous call having just failed and kept the error code from that failure. RESULT_GUARD does the same thing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.