fix: refactor rust bindings fingerprint methods #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Mar 25, 2024
maddeleine
changed the title
lrstewart
reviewed
Mar 26, 2024
camshaft
reviewed
Mar 28, 2024
maddeleine
force-pushed
the
server_name_fix
branch
from
f7b5492 to
202cc71
Compare
jmayclin
approved these changes
Mar 29, 2024
| use super::ClientHello; | ||
|
|
||
| #[derive(Copy, Clone)] | ||
| pub enum FingerprintType { |
There was a problem hiding this comment.
Not in the scope of this PR, but we should probably mark this non-exhaustive before we do the actual 0.2 release.
There was a problem hiding this comment.
We already did the 0.2 release :) But we can mark it now, since fingerprinting is unstable anyway.
lrstewart
approved these changes
Mar 29, 2024
Comment on lines
400
to
-227
| let message_head = self.raw_message().map_err(|_| fmt::Error)?; | ||
| let mut hash = Vec::new(); | ||
| self.fingerprint_hash(FingerprintType::JA3, &mut hash) | ||
| .map_err(|_| fmt::Error)?; |
There was a problem hiding this comment.
I'm disappointed that you couldn't figure out a way to keep this, but we can always add it back later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
The feature flag unstable-fingerprint was tagged to the client_hello method, which means that no one could retrieve the client hello or any of the getters on it without turning on the unstable-fingerprint flag. I uncoupled the client hello methods from the fingerprint feature by moving the fingerprint-specific code to a module.
Call-outs:
Testing:
Includes test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.