Add s2n_stuffer_shift #4458
Merged
Add s2n_stuffer_shift #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 14, 2024
camshaft
approved these changes
Mar 14, 2024
goatgoose
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a "s2n_stuffer_shift" method needed by an upcoming feature. It shifts all the unread data in a stuffer back to the beginning of the stuffer, freeing up more existing memory for new data.
Call-outs:
When I ran the CBMC proof with either real memcpy or real memmove, it consumed so many resources for so long that I lost access to my EC2 instance and had to replace it. But I wanted to be able to assert correct behavior, so I wrote a simple stub replacement.
Testing:
Unit tests, and a new CBMC proof.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.