ci: add asan runs under gcc #4402
Conversation
| cd third-party-src; | ||
| ln -s /usr/local $CODEBUILD_SRC_DIR/third-party-src/test-deps; | ||
| fi | ||
| - /usr/bin/$COMPILER --version |
There was a problem hiding this comment.
Do we expect a certain minimum gcc version to get "enough" asan coverage?
There was a problem hiding this comment.
Hmm. I do really like that idea, but I don't want to do it directly in the buildspec. Perhaps it would make sense to add a codebuild script like codebuild/bin/assert_compiler_version_gt $COMPILER "clang-15". I'll do that in a different PR to keep this one straightforward.
There was a problem hiding this comment.
Right- I'm not asking for it as part of this PR, (totally agree the buildspec probably isn't the right place) just wondering if it's written down anywhere...
|
I think we might have the override to merge this one. I have manually kicked off all of the codebuild jobs, but the unitNix and ASAN jobs won't report their results successful ASAN CI Update: |
Description of changes:
Add asan jobs for GCC
This PR also turns on Debug info for the builds, which allows line numbers to be included in the stack traces.
Testing:
I'll manually invoke the CI run so it should still show up as passing on this PR, and the compiler version will be verified in the output because of the new
compiler --versioncommand that I added in the buildspec.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.