fix(bindings): remove optional cmake dependency #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
Jan 9, 2024
jmayclin
approved these changes
Jan 9, 2024
camshaft
force-pushed
the
rust-no-cmake
branch
from
57d586f to
31c92b1
Compare
dougch
pushed a commit
to dougch/s2n-tls
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In #4283 we removed the PQ implementation in favor of using the underlying libcrypto implementation. The Rust build logic wasn't updated as part of that PR, though.
This change fixes PQ builds for the Rust bindings by removing the
cmakebuild entirely, which isn't needed anymore.Call-outs:
I've kept the
cmakefeature flag on thes2n-tls-syscrate, in case any customers were enabling it. But no one should notice that we aren't supporting buildingcmakeanymore.Testing:
I've tested the change locally as well as the CI build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.