fix: probe for all AES_GCM ktls variants #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
changed the title
lrstewart
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
I was wondering if we might be able to avoid adding future crypto_infos here by just including a whole /crypto header. But then we'd have to be REALLY careful about what else that header included, so that we wouldn't fail because of other feature probes' unavailable features.
|
Yeah that might have some false-negatives where ktls gets disabled just because, for example, the include path isn't setup correctly for the probe or it starts referring to other s2n-tls headers... But, yeah, currently it's also non-ideal trying to keep the actual code that uses the probed functionality and the probe itself in sync. |
maddeleine
approved these changes
Nov 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
On some linux platforms, only the
AES_GCM_128ktls definitions are available. Ideally, we would probe for each cipher independently from one another. However, as a short-term fix, this change adds theAES_GCM_256variant to the ktls feature probe to avoid build failures.Testing:
I tested this locally with a musl build (which doesn't export
AES_GCM_256). Our ktls CI tests should prevent regressions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.