Remove NULLs in s2n_kex #4293
Merged
Remove NULLs in s2n_kex #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Nov 16, 2023
maddeleine
reviewed
Nov 17, 2023
maddeleine
reviewed
Nov 17, 2023
maddeleine
approved these changes
Nov 17, 2023
jmayclin
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Small change to not use "NULL" as the TLS1.3 key exchange method.
Using NULL for the TLS1.3 kex leads to some annoying branching when checking whether a cipher suite has perfect forward secrecy. We have to comment "NULL means TLS1.3, which is always ephemeral" everywhere we want to check kex->is_ephemeral.
NULLs can also mean that a bug results in a seg fault instead of just an error.
Testing:
Existing tests pass. I also reviewed everywhere is_ephemeral, server_key_recv_read_data, and server_key_recv_parse_data is used to make sure there's no unintended and untested side effects of removing the NULL (like, intentional branching on the NULL). Everything looks fine.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.