feat: Adds ConnectionInitializer to Rust bindings #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Oct 17, 2023
jmayclin
reviewed
Oct 18, 2023
lrstewart
reviewed
Oct 19, 2023
|
Going to close this PR for now. Decided to attempt an Async version of the connection::Builder instead. |
maddeleine
force-pushed
the
client_resumption
branch
from
1980c7a to
1103f6d
Compare
lrstewart
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
Adds an async callback that gets triggered before s2n_poll_negotiate in order to dynamically configure the s2n connection. Users should create this callback when the config is built, and it will trigger each time a new connection is negotiated.
This is relevant to session resumption as the user can configure a callback to dynamically give session tickets to the s2n connection.
Call-outs:
N/A
Testing:
Includes modifications to the rust bindings resumption test to use this callback.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.