feat: Turns off automatic ticket creation for quic #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Oct 10, 2023
goatgoose
reviewed
Oct 10, 2023
goatgoose
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Related to #4124
Description of changes:
Small optimization for QUIC resumption. s2n servers with quic enabled will not send a session ticket to the client if the client didn't indicate support for TLS1.3 resumption with the psk_ke extension or the advertised mode is not psk_dhe_ke (our only supported mode.)
Keeps the legacy behavior the same if quic is not enabled.
Call-outs:
Is my testing overkill?
Testing:
Adds unit test and functional tests since I want to test the interaction between the extension code and the post-handshake code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.