Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize requests to GitHub API in Run CBMC proofs workflow #4223

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

qinheping
Copy link
Contributor

@qinheping qinheping commented Sep 26, 2023

The step install latest CBMC in run_cbmc_proofs CI workflow seems to be failing sporadically. Sometimes the failure disappears when the CI job is re-run but sometimes the failure does not disappear.

The error looks like:

jq: error (at <stdin>:1): Cannot index string with string "assets"
Error: Process completed with exit code 1.

Resolved issues:

model-checking/cbmc-starter-kit#200

Description of changes:

This PR changes the Run CBMC proofs workflow so that it authorizes the requests to the GitHub API with the secret available through ${{ secrets.GITHUB_TOKEN }}. I've followed the example shown in GitHub documentation here. Unfortunately, changes to GA workflows cannot be reliably test, especially considering that the failure is intermittent.

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft
Copy link
Contributor

I'm pretty sure the issue is that the GitHub API is rate limiting the call. This is especially an issue when several PRs get submitted at once.

@qinheping qinheping changed the title Fix cbmc installation in CI Authorize requests to GitHub API in Run CBMC proofs workflow Sep 26, 2023
@qinheping
Copy link
Contributor Author

I'm pretty sure the issue is that the GitHub API is rate limiting the call. This is especially an issue when several PRs get submitted at once.

Yes, there is a similar issue in aws-c-common: awslabs/aws-c-common#1057. I update the change in this PR to authorizes the requests to the GitHub API with the secret available through ${{ secrets.GITHUB_TOKEN }} as suggested.

The issue is similar to the one in this discussion. As mentioned in the last comment, it's possible that requests to the GitHub API are being rate-limited since they're not being authorized.

@dougch dougch self-requested a review September 26, 2023 23:10
@camshaft camshaft merged commit 5af7d6c into aws:main Sep 26, 2023
23 checks passed
@qinheping qinheping deleted the fix-cbmc-install branch September 27, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants