ktls: receive app data #4201
Merged
ktls: receive app data #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Sep 15, 2023
goatgoose
approved these changes
Sep 16, 2023
maddeleine
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4168
Description of changes:
A very simple change to enable us to receive application data with ktls. We just let s2n_ktls_read_full_record behave exactly like it does without ktls. The PR is mostly just tests.
However, while this method of handling s2n_recv + ktls is very simple and easy to understand, it introduces an extra copy / extra memory buffer because we read data into conn->in instead of the application's buffer. This reduces the benefit you get from ktls.
Call-outs:
I'm pushing this as a simple, working solution. I'll need to follow up on memory optimization for recv (including #4199 (comment)), but that's probably best done separately. An optimized version won't anywhere near as clean :( But getting the tests in place now should help: s2n_recv_test and s2n_self_talk_ktls_test really shouldn't change.
Testing:
Unit and self-talk tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.