Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Subset of #4048 to allow builds that use cmake or nix to enable ASAN.
Call-outs:
This doesn't remove the existing CI builds that use make for ASAN. It just allows new builds to use cmake or nix for ASAN.
Testing:
I intentionally created a memory leak in s2n_ktls_io_test and used nix to run the test.
$ clean; S2N_CMAKE_OPTIONS="-DASAN=ON" configure
output includes "Running tests with environment: S2N_DONT_MLOCK=1;S2N_ADDRESS_SANITIZER=1"$ unit
reports:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.