fix: remove broken check in test #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
Mar 22, 2023
goatgoose
approved these changes
Mar 22, 2023
+1; the "if true" case is necessary. the "else" case is not, but I'm surprised by it failing. I'll dig into the details. please assign the issue to me. |
Created ticket #3902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The following check in the test doesnt work as intended and fails in certain environments. The remaining code is fine and tested so we are only removing the excessive check which was added in #3853.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.