NULL-check s2n_cert_chain_and_key_get_pkey_type #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipberndt
force-pushed
the
fix-pkey-type
branch
from
f508678 to
474e135
Compare
|
I don't have access to the failing s2nIntegrationBatch, help or instructions how to get access would be appreciated! |
lrstewart
reviewed
Sep 21, 2021
phillipberndt
force-pushed
the
fix-pkey-type
branch
2 times, most recently
from
7a63577 to
4be4138
Compare
This adds a check to guard the case where a certificate chain is empty. In case it is, S2N_PKEY_TYPE_UNKNOWN is returned.
phillipberndt
force-pushed
the
fix-pkey-type
branch
from
4be4138 to
55b3f40
Compare
lrstewart
approved these changes
Sep 22, 2021
toidiu
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds POSIX_ENSURE_REF to guard the case where a certificate chain
is empty.
Resolved issues:
resolves #3063
Description of changes:
s2n_cert_chain_and_key_get_pkey_typecan be called with empty certificate chains. Adding the check prevents a NULL pointer dereference.