Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit memcmp usage #3059

Merged
merged 2 commits into from
Sep 22, 2021
Merged

audit memcmp usage #3059

merged 2 commits into from
Sep 22, 2021

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Sep 18, 2021

Resolved issues:

Description of changes:

s2n codes should use s2n_constant_time_equals instead of memcmp.

This PR adds a check for uses of memcmp to codebuild/bin/grep_simple_mistakes.sh, which is run as part of CI for each PR. It notes the current uses of 'memcmp' and will flag any future PRs which add or remove uses.

This should give better visibility into new uses of 'memcmp' while reviewing the PR and also help target/replace the current uses.

Issue to audit and replace memcmp usage: #3062

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu changed the title add check for memcmp uses audit memcmp usage Sep 20, 2021
@dougch dougch self-requested a review September 20, 2021 20:02
Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a tracking issue to actually fix the ones that are currently there? If so can you link it here? Otherwise please create one.

@toidiu toidiu requested review from dougch and lrstewart September 21, 2021 02:48
@toidiu toidiu force-pushed the ak-memcmp branch 2 times, most recently from f427fcb to 60e5f14 Compare September 21, 2021 18:38
@toidiu toidiu merged commit 01da77d into aws:main Sep 22, 2021
@toidiu toidiu deleted the ak-memcmp branch September 22, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants