Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Description of changes:
s2n codes should use
s2n_constant_time_equals
instead ofmemcmp
.This PR adds a check for uses of
memcmp
tocodebuild/bin/grep_simple_mistakes.sh
, which is run as part of CI for each PR. It notes the current uses of 'memcmp' and will flag any future PRs which add or remove uses.This should give better visibility into new uses of 'memcmp' while reviewing the PR and also help target/replace the current uses.
Issue to audit and replace memcmp usage: #3062
Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.