Skip to content

Commit

Permalink
Fix comment linter
Browse files Browse the repository at this point in the history
  • Loading branch information
WillChilds-Klein committed Sep 29, 2023
1 parent f668698 commit d4db3c2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions tests/unit/s2n_tls13_hybrid_shared_secret_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,9 +414,9 @@ int main(int argc, char **argv)
EXPECT_NOT_NULL(client_conn = s2n_connection_new(S2N_CLIENT));
EXPECT_NOT_NULL(server_conn = s2n_connection_new(S2N_SERVER));

// Expect success here regardless of whether a given |kem_group| is
// available because we will fall back on ECDH if no KEMs are
// available.
/* Expect success here regardless of whether a given |kem_group| is
* available because we will fall back on ECDH if no KEMs are
* available. */
EXPECT_SUCCESS(set_up_conns(client_conn, server_conn, test_vector->client_ecc_key,
test_vector->server_ecc_key, kem_group, test_vector->pq_secret));

Expand Down
8 changes: 4 additions & 4 deletions tls/extensions/s2n_server_key_share.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,10 @@ static int s2n_server_key_share_recv(struct s2n_connection *conn, struct s2n_stu
} else if (s2n_kem_preferences_includes_tls13_kem_group(kem_pref, negotiated_named_group_iana)) {
POSIX_GUARD(s2n_server_key_share_recv_pq_hybrid(conn, negotiated_named_group_iana, extension));
} else if (!s2n_pq_is_enabled() && negotiated_named_group_iana >= TLS_PQ_KEM_GROUP_ID_START) {
// |s2n_kem_preferences_includes_tls13_kem_group| will return false if
// PQ is disabled and thus no KEM groups are supported, so check
// whether the IANA name we've recieved indicates PQ KEM and return an
// appropriate error.
/* |s2n_kem_preferences_includes_tls13_kem_group| will return false if
* PQ is disabled and thus no KEM groups are supported, so check
* whether the IANA name we've recieved indicates PQ KEM and return an
* appropriate error. */
POSIX_BAIL(S2N_ERR_PQ_DISABLED);
} else {
POSIX_BAIL(S2N_ERR_ECDHE_UNSUPPORTED_CURVE);
Expand Down
2 changes: 1 addition & 1 deletion tls/s2n_tls_parameters.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
* https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
*/
#define TLS_PQ_KEM_GROUP_ID_X25519_KYBER_512_R3 0x2F39
#define TLS_PQ_KEM_GROUP_ID_START TLS_PQ_KEM_GROUP_ID_X25519_KYBER_512_R3
#define TLS_PQ_KEM_GROUP_ID_START TLS_PQ_KEM_GROUP_ID_X25519_KYBER_512_R3
#define TLS_PQ_KEM_GROUP_ID_SECP256R1_KYBER_512_R3 0x2F3A
#define TLS_PQ_KEM_GROUP_ID_SECP384R1_KYBER_768_R3 0x2F3C
#define TLS_PQ_KEM_GROUP_ID_SECP521R1_KYBER_1024_R3 0x2F3D
Expand Down

0 comments on commit d4db3c2

Please sign in to comment.