fix(s2n-quic-platform): don't reduce rx MTU when tx MTU is reduced #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #2155
Description of changes:
Previously, when the syscall to configure MTU discovery failed, we would reduce the MTU used for both transmitting and receiving packets to the minimum MTU. This can prevent receiving packets from peers that are using a larger MTU. This change will only reduce the MTU for transmitting packets, leaving the rx MTU at the originally configured value.
Testing:
Tested locally on MacOS, where the configure_mtu_disc syscall fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.