feat(s2n-quic-transport): support exporting from TLS sessions #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
tls-exporter
branch
3 times, most recently
from
20aa2ab to
8051eca
Compare
camshaft
reviewed
Oct 4, 2023
Mark-Simulacrum
force-pushed
the
tls-exporter
branch
2 times, most recently
from
72220ca to
efe6a4e
Compare
|
Remaining CI failure looks to be due to stable release adding new clippy breakage, not in files modified by this PR. |
Mark-Simulacrum
force-pushed
the
tls-exporter
branch
3 times, most recently
from
1392984 to
cfd32ca
Compare
|
OK, incorporated s2n-tls availability and added a test that makes sure this works. |
Mark-Simulacrum
force-pushed
the
tls-exporter
branch
from
cfd32ca to
c810a4e
Compare
camshaft
reviewed
Oct 11, 2023
| @@ -0,0 +1,120 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Really like the test here! Nice work
This also bumps s2n-tls dependency to 0.0.39 so that we can make use of the new TLS-Exporter functionality in s2n-tls, not just in rustls.
Mark-Simulacrum
force-pushed
the
tls-exporter
branch
from
c810a4e to
7b36fbd
Compare
camshaft
changed the title
camshaft
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds support for exporting symmetric keys from the negotiated QUIC connection for use by other applications/protocols. See https://datatracker.ietf.org/doc/html/rfc5705 for some further details.
See s2n-tls upstream (aws/s2n-tls#4230), released as part of s2n-tls 0.0.39 on crate.io. rustls already supports the relevant API.
Call-outs:
The event API is somewhat novel as added here, but should be relatively extensible and works out ok.
Testing:
New test added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.