fix for issue 305 #309
Merged
fix for issue 305 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotok
reviewed
Mar 28, 2022
| int shingleSize = state.getShingleSize(); | ||
| int baseDimension = dimensions / shingleSize; | ||
| for (int i = 0; i < tempList.length; i++) { | ||
| checkArgument(tempList[i] % baseDimension == 0, " incorrect state"); |
There was a problem hiding this comment.
Can we provide a more descriptive error message?
There was a problem hiding this comment.
agree, not so easy to get what's wrong with the general error message
ylwu-amzn
added a commit
to ylwu-amzn/anomaly-detection-2
that referenced
this pull request
Mar 28, 2022
ylwu-amzn
approved these changes
Mar 28, 2022
jotok
approved these changes
Mar 28, 2022
This was referenced Apr 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Issue 305. The most recent changes to main broke the state classes older models (version 2.0.1).
Description of changes: Changes the PointStoreMapper to address the transformation and adds tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.