clear self-test flag #153
clear self-test flag #153
Conversation
| @@ -774,6 +774,12 @@ static OtaErr_t inSelfTestHandler( const OtaEventData_t * pEventData ) | |||
| { | |||
| /* Callback for application specific self-test. */ | |||
| otaAgent.OtaAppCallback( OtaJobEventStartTest, NULL ); | |||
|
|
|||
| /* Clear self-test flag. */ | |||
| otaAgent.fileContext.isInSelfTest = false; | |||
There was a problem hiding this comment.
The logic determining whether or not OTA is in self-test is difficult to follow. Sometimes we call an internal function inSelfTest() which in turn calls a PAL function to see if it is in the "pending commit" state. In other cases, we examine this isInSelfTest internal member of the file context.
It also looks like the isInSelfTest member of the file context is never set to true in the code, so I'm assuming this value can only come from the service?
Overall comment here – can the logic around the "Self Test" state be simplified? As it is written it is likely to be difficult to maintain since the state information for "in self test" is located and modified in different places.
There was a problem hiding this comment.
This is good point. The main reason for confusion is the inSelfTest function is actually checking the platform is in self test or not. Wheras the flag in the OTA context is the runtime self-test. The inSelfTest function should be renamed to indicate that it is checking platform state platformInSelfTest. This is fixed in 17664db
Issue #, if available:
Description of changes:
The change clears the self-test flag.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.