Add transform logSuggestionForFailureResponse #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonlouie
approved these changes
Oct 7, 2024
pranav-firake
approved these changes
Oct 7, 2024
ege0zcan
reviewed
Oct 7, 2024
| let suggestion = '' | ||
| if (reason.toLowerCase().includes('build validation failed')) { | ||
| suggestion = | ||
| 'Please close Visual Studio, delete the directories where build artifacts are generated (e.g. bin and obj), and try running the transformation again.' |
There was a problem hiding this comment.
Do we expect this server to be only used in visual studio and no other IDE? Otherwise I would reword this to Please close your IDE
There was a problem hiding this comment.
Yes, it's only used in visual studio.
ege0zcan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following up comments on this PR: #476
There are probably other places where we log some suggestion after a failure message.
Solution
Addressed comments on the above mentioned PR. Rephrase the suggestion message and put it into a function.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.