move default provisioner to helm post-install hook #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 9f4188f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61944aa6fb7d3800086616b3 😎 Browse the preview: https://deploy-preview-810--karpenter-docs-prod.netlify.app |
njtran
reviewed
Nov 17, 2021
ellistarn
reviewed
Nov 17, 2021
| @@ -3,6 +3,9 @@ apiVersion: karpenter.sh/v1alpha5 | |||
| kind: Provisioner | |||
| metadata: | |||
| name: default | |||
| annotations: | |||
| "helm.sh/hook": post-install | |||
| "helm.sh/resource-policy": keep | |||
There was a problem hiding this comment.
this tells helm that it's a post-install hook and to keep the resource rather than deleting it right after applying.
ellistarn
reviewed
Nov 17, 2021
| @@ -50,7 +50,10 @@ func (m *GenericControllerManager) RegisterControllers(ctx context.Context, cont | |||
| } | |||
| } | |||
| if err := m.AddHealthzCheck("healthz", healthz.Ping); err != nil { | |||
There was a problem hiding this comment.
Can you call this livez (liveness)
There was a problem hiding this comment.
I can't tell if this is a joke. If it's not, the convention is healthz for liveness check
ellistarn
approved these changes
Nov 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
N/A
2. Description of changes:
post-install-hookresource. Helm resources applied in a post-install-hook are applied after the regular release resources are applied and are technically not part of the release. If you specify the--waitflag when helm installing, the post-install-hook will wait until release resources are in a Ready state. So, I have added readiness probes to both the controller and webhook deployments so that helm is signaled properly to begin the post-install-hook.3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.