Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade helm-docs #1658

Merged
merged 1 commit into from
Apr 11, 2022
Merged

upgrade helm-docs #1658

merged 1 commit into from
Apr 11, 2022

Conversation

bwagner5
Copy link
Contributor

1. Issue, if available:
N/A

2. Description of changes:

  • helm-docs v1.7.0 causes a checksum mismatch when using GOPROXY=direct, v1.8.1 is a stable release that matches the checksum
  • helm-docs v1.7.0 depends on golang.org/x/sys/unix@20190215142949 which doesn't work with go 1.18 on darwin
$ go verison 
go version go1.17.8 darwin/amd64

$ GOPROXY=direct go install github.com/norwoodj/helm-docs/cmd/[email protected]
 # golang.org/x/sys/unix
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:136:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:151:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:166:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:166:3: too many errors

3. How was this change tested?

$ go version
go version go1.18 darwin/amd64

$ GOPROXY=direct go install github.com/norwoodj/helm-docs/cmd/[email protected]
$ echo $?
0

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner April 11, 2022 16:29
@bwagner5 bwagner5 requested a review from njtran April 11, 2022 16:29
@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 52309c5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6254576f719e470008386363
😎 Deploy Preview https://deploy-preview-1658--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit c4b2e7b into aws:main Apr 11, 2022
@bwagner5 bwagner5 deleted the helm-docs-upgrade branch April 11, 2022 17:04
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants