Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick patch with conflict fix onto release-v1.0.x #7054

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 23, 2024

Fixes #N/A

Description

Cherry-pick change from #1658 onto release-v1.0.x

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 23, 2024 07:43
@jonathan-innis jonathan-innis force-pushed the cherry-pick-patch-with-conflict branch from efa1bda to aff9635 Compare September 23, 2024 07:44
@jonathan-innis jonathan-innis marked this pull request as draft September 23, 2024 07:44
@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 10998687738

Details

  • 12 of 18 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 79.392%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/status/controller.go 9 15 60.0%
Totals Coverage Status
Change from base Build 10931688317: -0.007%
Covered Lines: 5956
Relevant Lines: 7502

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the cherry-pick-patch-with-conflict branch from aff9635 to aefd2f9 Compare September 23, 2024 16:38
@jonathan-innis jonathan-innis force-pushed the cherry-pick-patch-with-conflict branch from aefd2f9 to 48dfc01 Compare September 23, 2024 16:43
@jonathan-innis jonathan-innis marked this pull request as ready for review September 23, 2024 16:43
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 23, 2024 16:43
@jonathan-innis jonathan-innis merged commit edda848 into aws:release-v1.0.x Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants