Separate the command line commands in the getting started guide last part #1429
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: bf4b548 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622020a582560f0007059d36 😎 Browse the preview: https://deploy-preview-1429--karpenter-docs-prod.netlify.app |
spring1843
changed the title
website/content/en/preview/getting-started/scripts/add-graphana.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/add-provisioner.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/add-graphana.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/add-provisioner.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/step15-delete-node.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/step12-add-provisioner.sh
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/scripts/step14-automatic-node-termination.sh
Outdated
Show resolved
Hide resolved
@bwagner5 The steps that I have separated are those that are either separate concerns, or complex to do in one shot because we need to wait in between, and check the status and etc... Adding all of them to install.sh would break install.sh at this point and make it less useful. Furthermore this doesn't stop us from having a script that does add the monitoring as well, I'll probably have to add some steps to the scripts that aren't in the documentation, so if you don't mind I'll have that as a separate PR when it's ready. |
1. Issue, if available:
2. Description of changes:
Similar to #1412
Includes all the rest of the scripts in the getting started guide.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.