Separate the command line commands in the getting started guide into independent bash files #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bash files and adds a run-all-steps.sh file that sequentially runs all those files. By running the run-all-steps.sh we can verify that all steps work
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 7bc8090 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62183a19304db900084c452f 😎 Browse the preview: https://deploy-preview-1412--karpenter-docs-prod.netlify.app |
bwagner5
reviewed
Feb 24, 2022
website/content/en/preview/getting-started/scripts/run-all-steps.sh
Outdated
Show resolved
Hide resolved
bwagner5
reviewed
Feb 24, 2022
ellistarn
reviewed
Feb 24, 2022
bwagner5
reviewed
Feb 24, 2022
ellistarn
reviewed
Feb 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
Relates to:
#1351
#1358
#1344
2. Description of changes:
Separates the CLI parts of the getting started guide into independent bash files and adds a run-all-steps.sh file that sequentially runs all those files.
Some of the benefits of this change:
The appearance of the docs will remain unchanged after this change with the exception of introducing a new environment variable (KARPENTER_VERSION).
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.