Allow EC2 "Name" tag to be supplied in the provisioner spec #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 14b509f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61b7b87d62c76e0008563faa 😎 Browse the preview: https://deploy-preview-964--karpenter-docs-prod.netlify.app |
ellistarn
reviewed
Dec 10, 2021
ellistarn
reviewed
Dec 10, 2021
ellistarn
reviewed
Dec 10, 2021
ellistarn
reviewed
Dec 10, 2021
Fixing typo in docs Co-authored-by: Ellis Tarn <[email protected]>
…sioner/<provisioner-name>
ellistarn
reviewed
Dec 13, 2021
| "Name": fmt.Sprintf("karpenter.sh/%s", clusterName), | ||
| fmt.Sprintf(ClusterTagKeyFormat, clusterName): "owned", | ||
| fmt.Sprintf(KarpenterTagKeyFormat, clusterName): "owned", | ||
| func MergeTags(ctx context.Context, customTags map[string]string) []*ec2.Tag { |
There was a problem hiding this comment.
Optional: put this on the aws object.
func (a *AWS) GetTags()
auto-merge was automatically disabled
December 13, 2021 21:17
Head branch was pushed to by a user without write access
ellistarn
approved these changes
Dec 13, 2021
|
Thank you! Will cut a release soon. |
jkroepke
added a commit
to jkroepke/karpenter
that referenced
this pull request
Apr 10, 2022
README: add link to Netlify dashboard (aws#964)
bwagner5
added a commit
that referenced
this pull request
Apr 25, 2022
* chart: Added extraVolumes and extraVolumeMounts README: add link to Netlify dashboard (#964) * Update charts/karpenter/templates/deployment.yaml Co-authored-by: Brandon Wagner <[email protected]> * Update charts/karpenter/templates/deployment.yaml Co-authored-by: Brandon Wagner <[email protected]> Co-authored-by: Brandon Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#944
2. Description of changes:
These changes allow the EC2 "Name" tag to be set in the provisioner spec as:
If the Name tag is not supplied in the spec, the logic falls back to the previous default value of
Name: karpenter.sh/<cluster-name>3. Does this change impact docs?
4. Testing
All local tests passed
In addition to the above local tests, the updated images were built locally and pushed to my development ECR. The updated chart was then deployed and the code changes were tested in AWS EKS.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.