Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for v0.5.2 and fix nav issues #960

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Conversation

geoffcline
Copy link
Contributor

1. Issue, if available:
new release

2. Description of changes:
add docs for v0.5.2 and fix nav issues

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: c1b8d94

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61b268f1d0ea130008d11c44

@@ -66,7 +66,7 @@ anchor = "smart"
## Site Params
[params]

latest_release_version = "0.5.1"
latest_release_version = "0.5.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is used everywhere for all versions of docs, unfortunately. It would be nice if we somehow had access to params.versions[something].version. I couldn't figure this out though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to block on this, though.

@geoffcline
Copy link
Contributor Author

@akestner will you take a look at why this failed? The log is curious to me

2:37:19 PM: No changes detected in base directory. Returning early from build.
2:37:20 PM: Creating deploy upload records
2:37:20 PM: Failed during stage 'checking build content for changes': Canceled build due to no content change
2:37:20 PM: Finished processing build request in 12.537953172s

@ellistarn ellistarn merged commit 79e38fb into aws:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants