First phase of scheduler refactor #931
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 6dd0dfa 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61aea2d7ca637e00072e9324 😎 Browse the preview: https://deploy-preview-931--karpenter-docs-prod.netlify.app |
| @@ -161,3 +190,91 @@ func (p *Provisioner) FilterProvisionable(ctx context.Context, pods []*v1.Pod) [ | |||
| } | |||
| return provisionable | |||
| } | |||
|
|
|||
| func (p *Provisioner) launch(ctx context.Context, constraints *v1alpha5.Constraints, packing *binpacking.Packing) error { | |||
There was a problem hiding this comment.
Why did we collapse the launcher into this file btw? Don't feel too strongly about it either way
There was a problem hiding this comment.
It will become more apparent as I continue to refactor this, but essentially the logic got small enough that it didn't really make sense to have all of the overhead ~70 lines of code. Additionally, I'm going to be moving other provisioner behavior (e.g. batching/scheduling) elsewhere. You can think about the provisioner as becoming a renamed launcher.
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.