Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix toolchain install for arm64 mac #918

Merged
merged 1 commit into from
Dec 4, 2021
Merged

fix toolchain install for arm64 mac #918

merged 1 commit into from
Dec 4, 2021

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Dec 4, 2021 •
edited
Loading

1. Issue, if available:
N/A

2. Description of changes:

  • Upped k8s bins for testing from 1.19 to 1.21
  • Currently, Karpenter's make toolchain fails on arm64 (m1) macs because of kubebuilder's setup-env which downloads k8s component binaries which are not available for the darwin/arm64 platform. Macs with arm64 processors are able to run x86 compiled binaries using Rosetta virtualization which happens transparently to the user when executing an x86 binary.

This change overrides the machine's architecture to amd64 if running on an arm64 mac. Previously, the command would fail to fetch the binaries and tests could not be run.

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 4, 2021 •
edited
Loading

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: e250190

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61abf78417a7b800083c9b92

@bwagner5 bwagner5 requested a review from ellistarn December 4, 2021 23:19
@ellistarn
Copy link
Contributor

You lucky dog.

@ellistarn ellistarn merged commit c3b37d9 into aws:main Dec 4, 2021
bdwyertech added a commit to bdwyertech/karpenter that referenced this pull request Dec 7, 2021
@bdwyertech
Merge commit '5392413df2fc6963ea1f80a6cc88970c73abcda2' into ensure-l…
64527ec 
…abeled

* commit '5392413df2fc6963ea1f80a6cc88970c73abcda2':
  Updated developer guide with additional guidance (aws#929)
  docs: use site params to reference latest release (aws#925)
  fix toolchain install for arm64 mac (aws#918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwagner5 @ellistarn