-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve display of releases in navbar #906
feat: improve display of releases in navbar #906
Conversation
Signed-off-by: Tuan Anh Tran <[email protected]>
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: e727612 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61aedd5a14b7c40007fea3df 😎 Browse the preview: https://deploy-preview-906--karpenter-docs-prod.netlify.app |
@geoffcline can you take a look? |
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
|
i think i need to update netlify.toml too to apply the patch for preview. apparently, it's not using make website command EDIT: netlify works now |
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Will this ensure that the docs version dropdown is visible on mobile devices as well? |
ok now ;) |
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
This lgtm. Is the pre-release version added to config.toml manually when we have one to deploy? I don't see any problem carrying the patch in layouts/partials because that's where you're supposed to modify/extend docsy anyway. It would be nice to be an option upstream but I don't think it should block this PR if it's not there. |
@geoffcline have all your issues been addressed? If so, /lgtm from me. |
Wonderful, thank you! |
Signed-off-by: Tuan Anh Tran [email protected]
1. Issue, if available:
#826
2. Description of changes:
show the latest version in navbar + style pre-release in gray color
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.