Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated an inaccurate comment #895

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Updated an inaccurate comment #895

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd86556
Updated an inaccurate comment
ellistarn Dec 2, 2021
e4b5396
Included codegen
ellistarn Dec 2, 2021
9470f66
PR comments
ellistarn Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions charts/karpenter/crds/karpenter.sh_provisioners.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,10 @@ spec:
type: object
spec:
description: ProvisionerSpec is the top level provisioner specification.
Provisioners launch nodes in response to pods where status.conditions[type=unschedulable,
status=true]. Node configuration is driven by through a combination
of provisioner specification (defaults) and pod scheduling constraints
(overrides). A single provisioner is capable of managing highly diverse
capacity within a single cluster and in most cases, only one should
be necessary. It's possible to define multiple provisioners. These provisioners
may have different defaults and can be specifically targeted by pods
using pod.spec.nodeSelector["karpenter.sh/provisioner-name"]=$PROVISIONER_NAME.
Provisioners launch nodes in response to pods that are unschedulable.
A single provisioner is capable of managing diverse set of nodes. Node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: managing a diverse set of nodes

properties are determined from a combination of provisioner and pod
scheduling constraints.
properties:
labels:
additionalProperties:
Expand Down
11 changes: 3 additions & 8 deletions pkg/apis/provisioning/v1alpha5/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,9 @@ import (
)

// ProvisionerSpec is the top level provisioner specification. Provisioners
// launch nodes in response to pods where status.conditions[type=unschedulable,
// status=true]. Node configuration is driven by through a combination of
// provisioner specification (defaults) and pod scheduling constraints
// (overrides). A single provisioner is capable of managing highly diverse
// capacity within a single cluster and in most cases, only one should be
// necessary. It's possible to define multiple provisioners. These provisioners
// may have different defaults and can be specifically targeted by pods using
// pod.spec.nodeSelector["karpenter.sh/provisioner-name"]=$PROVISIONER_NAME.
// launch nodes in response to pods that are unschedulable. A single provisioner
// is capable of managing diverse set of nodes. Node properties are determined
// from a combination of provisioner and pod scheduling constraints.
type ProvisionerSpec struct {
// Constraints are applied to all nodes launched by this provisioner.
Constraints `json:",inline"`
Expand Down