Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reformat webhook rbac file #883

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Dec 1, 2021

Signed-off-by: Tuan Anh Tran [email protected]

1. Issue, if available:
#554

2. Description of changes:
reformat rbac file of webhook as per #554

3. Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: e52cc4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61a7da429cacad0008c0e7e5

@ellistarn
Copy link
Contributor

Hey @tuananh. Thanks for picking this up! This issue was actually to do the opposite of this formatting.

Preferred

list: [ "this", "is", "tidier"]

Current

list:
- this
- is
- verbose

@tuananh
Copy link
Contributor Author

tuananh commented Dec 1, 2021

Hey @tuananh. Thanks for picking this up! This issue was actually to do the opposite of this formatting.

Preferred

list: [ "this", "is", "tidier"]

Current

list:
- this
- is
- verbose

ah i mis-understood it. pr updated.

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Thank you!

@ellistarn ellistarn merged commit a156e6d into aws:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants