Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging touchups #852

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Minor logging touchups #852

merged 3 commits into from
Nov 26, 2021

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Nov 25, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 98b294f

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/619fd35639c72900084c5653

😎 Browse the preview: https://deploy-preview-852--karpenter-docs-prod.netlify.app

eptiger
eptiger previously approved these changes Nov 25, 2021
Copy link
Contributor

@eptiger eptiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving with the assumption that you've tested that the logging format still looks good

go.mod Outdated
@@ -25,6 +25,8 @@ require (
sigs.k8s.io/controller-runtime v0.9.7
)

require go.uber.org/zap v1.19.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why go mod tidy did this.

@ellistarn ellistarn merged commit d237072 into aws:main Nov 26, 2021
@ellistarn ellistarn deleted the metrics branch November 26, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants