Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always tag instances with managed tags and provisioner tags #813

Merged
merged 2 commits into from
Nov 19, 2021
Merged

always tag instances with managed tags and provisioner tags #813

merged 2 commits into from
Nov 19, 2021

Conversation

bwagner5
Copy link
Contributor

1. Issue, if available:
#793

2. Description of changes:

  • Tag all fleet launches w/ managed tags and provisioner tags. Previously this only worked when using the LT that karpenter generates. This now works with custom LTs.

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Nov 18, 2021 •
edited
Loading

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: fd76c14

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6196ea479ff47000083d4ad9

@bwagner5 bwagner5 requested a review from ellistarn November 18, 2021 23:35
ellistarn
ellistarn previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenicenice

pkg/cloudprovider/aws/launchtemplate.go Outdated Show resolved Hide resolved
pkg/cloudprovider/aws/apis/v1alpha1/tags.go Outdated Show resolved Hide resolved
@JacobGabrielson
Copy link
Contributor

🚢 ❗

@bwagner5 bwagner5 merged commit 9af7af0 into aws:main Nov 19, 2021
@bwagner5 bwagner5 deleted the tags branch November 19, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobGabrielson JacobGabrielson JacobGabrielson approved these changes

@ellistarn ellistarn ellistarn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwagner5 @JacobGabrielson @ellistarn