Added working group notes #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 553a17f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/618d66385ba70f000750013a |
suket22
reviewed
Nov 11, 2021
WORKING_GROUP.md
Outdated
| - CPU/GPU/Memory | ||
| - What about storage? Should we support all resource requests? | ||
| - spec.limits.resources vs spec.maxResources | ||
|
|
There was a problem hiding this comment.
I also captured this from our review which we can add in -
- This should support folks running separate provisioners per team.
- Helps a cluster admin enforce a limit on each team.
- Setting GPU limits to 0 can help enforce that no GPU instances are launched at all.
- Discussed resource quotas and why that doesn't help us implement limits in this form.
- With quotas you can limit resourceCounts (number of PVs) but not resource properties (say size of a PV)
ellistarn
commented
Nov 11, 2021
JacobGabrielson
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.