fix aws cp caching empty instance types set

[bwagner5]

1. Issue, if available:
N/A

2. Description of changes:

1. The AWS CP InstanceTypes provider was using a defer func to cache results. If the DescribeInstanceTypes call err'd for any reason, the defer block still runs and caches an empty value. On subsequent reconciliations, the scheduler would not fill in well known labels causing this logging:

2021-11-08T22:39:28.831Z	INFO	controller.allocation.provisioner/default	Ignored pod test1-basic-0-774f48fcd-hkf85/koi-test3, kubernetes.io/arch is too constrained: 
kubernetes.io/os is too constrained: 
node.kubernetes.io/instance-type is too constrained: 

2. The test I was running received a RequestLimitExceeded on the DescribeInstanceTypes call and resulted in an empty set of instance types cached.

2021-11-08T22:39:23.117Z	ERROR	controller.controller.Allocation	Reconciler error	{"commit": "82226ca", "reconciler group": "karpenter.sh", "reconciler kind": "Provisioner", "name": "default", "namespace": "", "error": "getting instance types, retrieving all instance types, fetching instance types using ec2.DescribeInstanceTypes, RequestLimitExceeded: Request limit exceeded.\n\tstatus code: 503

Since DescribeInstanceTypes should change very rarely, I set a custom cache TTL for the instance types and zones cache. The default it was using was set to 1 minute. I set the new value to 5 minutes.

3. I cleaned up some comment typos

4. Cleaned up some redundant error messages since we were wrapping and propagating errors in the InstanceTypes provider.

3. Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: link to issue
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 1fc775d

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/618c1631eda5f30008dcd4c7