chore: Fix IAM instance profile eventual consistency error

[jonathan-innis]

Fixes #N/A

Description

Fix IAM instance profile eventual consistency error that we are hitting when we have just deployed an IAM instance profile

validating ec2:RunInstances authorization, operation error EC2: RunInstances, https response error StatusCode: 400, RequestID: 80dcb2a2-8376-409e-a32c-378314b5799a, api error InvalidParameterValue: Value (consolidation-624112142_14082888993124779028) for parameter iamInstanceProfile.name is invalid. Invalid IAM Instance Profile name

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	791df8a
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/67c8eb0b6b35a300086d0c83

[jonathan-innis]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-791df8ab741802dc5b350c377998bcf32f2dc0e6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-791df8ab741802dc5b350c377998bcf32f2dc0e6" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

[coveralls]

Pull Request Test Coverage Report for Build 13688313337

Details

• 24 of 38 (63.16%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 67.126%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/errors/errors.go	9	13	69.23%
pkg/controllers/nodeclass/validation.go	15	25	60.0%

Totals
Change from base Build 13686923602:	-0.02%
Covered Lines:	6767
Relevant Lines:	10081

---

💛 - Coveralls

[jmdeal]

LGTM