-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topology now factors in affinity and global requirements (subnets) when computing spread #772
Conversation
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: ac5daa3 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/617c2710a881010007d19839 |
f9779b4
to
70a771e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick pass through. Nice refactor and bug fix :)
|
||
func (b *Binder) bind(ctx context.Context, node *v1.Node, pods []*v1.Pod) error { | ||
// 1. Add the Karpenter finalizer to the node to enable the termination workflow | ||
// Add the Karpenter finalizer to the node to enable the termination workflow | ||
node.Finalizers = append(node.Finalizers, v1alpha5.TerminationFinalizer) | ||
// 2. Taint karpenter.sh/not-ready=NoSchedule to prevent the kube scheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 2.
37e28c9
to
23b6342
Compare
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.