Chore: Log refresh credentials error #7540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 12384140991Details
💛 - Coveralls |
edibble21
force-pushed
the
maskautherror
branch
2 times, most recently
from
55e8258 to
113e643
Compare
njtran
reviewed
Dec 18, 2024
| if err == nil { | ||
| return false | ||
| } | ||
| if strings.Contains(err.Error(), "failed to refresh cached credentials") { |
There was a problem hiding this comment.
What's the code on this? Generally I'm not sure what the guarantees are on the formatting of this messaging that I worry about relying on it.
engedaam
reviewed
Dec 18, 2024
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Only log credential refresh errors instead of returning them to
Only log credential refresh errors instead of returning them to reduce alert noise in metrics.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.