update docs with --wait for helm chart install to avoid race #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: bbecea7 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6170a4b6c050560007ec21af 😎 Browse the preview: https://deploy-preview-754--karpenter-docs-prod.netlify.app |
ellistarn
reviewed
Oct 20, 2021
| ```bash | ||
| helm repo add karpenter https://awslabs.github.io/karpenter/charts | ||
| helm repo update | ||
| helm upgrade --install karpenter karpenter/karpenter --namespace karpenter \ | ||
| --create-namespace --set serviceAccount.create=false --version 0.4.0 | ||
| --create-namespace --set serviceAccount.create=false --version 0.4.0 \ | ||
| --wait |
There was a problem hiding this comment.
Consider
--wait # for the defaulting webhook to install before creating a Provisioner
aaroniscode
force-pushed
the
mutating_webhook_race
branch
from
afef990 to
2cc9293
Compare
aaroniscode
force-pushed
the
mutating_webhook_race
branch
from
2cc9293 to
bbecea7
Compare
ellistarn
approved these changes
Oct 20, 2021
JacobGabrielson
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Update docs to avoid a race condition if Karpenter install is automated and a Provisioner is created immediately after a Helm install. Without --wait on Helm install, it's possible for the Provisioner to created before the Mutating Admission Webhook configuration has taken effect.
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.