docs: Convert mentions of do-not-evict to do-not-disrupt
#7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the `do-not-evict` annotation.) Figured I'd clean that up to reduce confusion!
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
engedaam
requested changes
Dec 18, 2024
Pull Request Test Coverage Report for Build 12383535337Details
💛 - Coveralls |
I'd love to! Not sure how to make that happen, though. 😅 I saw a mention of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the
do-not-evictannotation.) Figured I'd clean that up to reduce confusion!NOTE: I'm not entirely sure how this works with already published docs versions, so any guidance there would be quite welcome. Thanks!
Probably doesn't need testing?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.