Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop deprecated AMI status condition #7512

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 10, 2024

Fixes #N/A

Description

  • Dropping the deprecated AMI status condition. We are in the process considering mechanisms to communicate nodeclass that are in a "Degraded" state, but are still able to provision capacity. The would like a general status condition that is able to describe multiple modes of degradation similar to deprecated AMIs

How was this change tested?

  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner December 10, 2024 20:25
@engedaam engedaam requested a review from jmdeal December 10, 2024 20:25
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9a4c3de
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6758a9831db9bc000819937e

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12264482751

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 65.027%

Totals Coverage Status
Change from base Build 12250744791: -0.04%
Covered Lines: 5738
Relevant Lines: 8824

💛 - Coveralls

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-43ce87f7cfd260151760891e436f9cb1f22983c1.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-43ce87f7cfd260151760891e436f9cb1f22983c1" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis
jonathan-innis previously approved these changes Dec 10, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit ae0d3e6 into aws:main Dec 10, 2024
17 checks passed
@engedaam engedaam deleted the drop-depricated-ami-status-condition branch December 10, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants